Closed ghost closed 7 years ago
@tarebyte I made a draft about the internationalization roadmap. I'm still concerned of any text generated by a external library that could be prompted at the screen. Could you take a look on it?
I'm still concerned of any text generated by a external library that could be prompted at the screen. Could you take a look on it?
@fabriciojr I think the best course of action here would be to crowd source the translations and avoid using a gem.
I think this guide http://guides.rubyonrails.org/i18n.html should give us a good starting place.
@tarebyte I think you misunderstood it, I wasn't thinking about using a gem, there's no good reason for it. My concern was about any text coming from external gems or JS libraries. Did you get it?
@fabriciojr oh I understand what you're saying. There is only once place where external next would come from and that is the repository auto completer.
For the most part we wrap the errors ourselves from the GitHub API.
@tarebyte Thanks for the two cents. I'll keep working on it. Can you assign this issue to me?
@fabriciojr unfortunately I can't because you aren't apart of the Education organization nor are you an outside collaborator. Sorry about that.
@tarebyte No problem, I'm going to start coding here. 😄
Is there any work being done on this?
I'd be happy to start picking off some of these objectives.
Hi! I've worked on I18n in Google Summer of Code this year and I would love to help in the internationalization process! :smile:
@jiteshjha @CGA1123 feel free! Pull Requests are always welcomed 😄
What file structure should be used for holding the translation strings?
|-views
|---shared
|-----en.yml
|---pages
|-----en.yml
(similar structure as mentioned here) Does something along those lines look reasonable?
Sticking with a single en.yml
in config/locales
doesn't seem like the best approach.
@CGA1123 I want to stick to the Rails convention to reduce the overhead for other people who work on this later.
Reference: http://guides.rubyonrails.org/i18n.html
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Shoo probot
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
As discussed in #308, this issue provides a roadmap to the project internationalization at all. Before add any new language inside classroom, the strings will be fully replaced by I18n keys. Each of the following changes needs to generate one pull request, this atomicity will make easier the code review, testing, tracking and collaboration on it.
Milestone 1: String to key replacing at views
In this milestone, we'll replace the strings on all classroom views, including the staff tools area.
Milestone 2: String to key replacing at controllers
In this milestone, we'll replace the strings that are located on controllers flash messages.