search

github-education-resources / teachers_pet

Command line tool to help teachers use GitHub in their classrooms
https://education.github.com/guide
MIT License
187 stars 74 forks source link

Merge all Pull Requests in a repo #77

Closed tarebyte closed 10 years ago

tarebyte commented 10 years ago

Closes #75

I wanted to see if this was the right direction for what you had in mind. If so I can finish it up by writing tests.

Let me know!

afeld commented 10 years ago

Thanks so much for working on this! What do you think about renaming the command to merge_pull_requests?

Needs a bit of cleanup and some tests, but it will be great to have this included.

tarebyte commented 10 years ago

Not a problem! I've been looking for open source projects where I can help out, GitHub education is one of those projects I really get excited about.

I like merge_pull_requests better than what I have. PR is a little too informal and would be ambiguous for users that are new to GitHub.

I'll clean this up later today, and once we're happy with the implementation I'll write tests to round out this PR.

afeld commented 10 years ago

Awesome, looks good! Just needs some tests :rocket:

tarebyte commented 10 years ago

@afeld any advice on why my tests are failing would be much appreciated.

I mentioned up in the line comments that I'm not sure why I don't need the organization in this case.

afeld commented 10 years ago

Getting close!

tarebyte commented 10 years ago

@afeld Everything should work now.

Thank you again for your help, this is a really neat project.

afeld commented 10 years ago

You rock! Thanks so much for doing this, excited to have you join the party.