github-for-unity / Unity

GitHub for Unity
https://unity.github.com/
MIT License
3.05k stars 447 forks source link

Fix GitHub sign in with a browser #1160

Open chantzish opened 2 years ago

chantzish commented 2 years ago

As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/

Requirements

Description of the Change

As of September 8 2021 github removed API authentication through query parameters - https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ . Changing to auth via "Authorization: token ..." header.

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

ZachArani commented 2 years ago

I just had to dig through several issue threads and find the instructions on how to apply this fix myself.

It's been over half a year and this basic functionality is still busted. Please fix this already.

naim commented 2 years ago

Can we get this merged and a patch release cut?

ChrisMenning commented 1 year ago

I can confirm that this bug is still present, and this fix works. Please merge.

Shain-Allen commented 1 year ago

I can also confirm that this bug is still present and that applying this fixes it