search

github-language-server / github-lsp

A simple LSP for helping with local edits of Wiki and README
MIT License
12 stars 2 forks source link

fix: bug with : and invalid searches #42

Closed AlexanderBrevig closed 7 months ago

AlexanderBrevig commented 7 months ago

Closes #41 thanks for the report!

Could you test it on your system @krfl ?

krfl commented 7 months ago

Spamming ::::::::: still causes it to seemingly hang or become blocked. All completions seem to be blocked for a while and then suddenly starts working again after 5-15 seconds or so.

AlexanderBrevig commented 7 months ago

Spamming ::::::::: still causes it to seemingly hang or become blocked. All completions seem to be blocked for a while and then suddenly starts working again after 5-15 seconds or so.

Thanks! I'm able to reproduce with that rather insane ;) test input :)

I've added timeouts to all completion requests now, should be more solid even if a few weird searches slip through (like searching for a : user)

krfl commented 7 months ago

3e4e17e did the trick. I'm unable to crash it with previously used methods.