search

github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.35k stars 4.27k forks source link

.hh files (HHVM) incorrectly recognized as C++ #1000

Closed fredemmott closed 9 years ago

fredemmott commented 10 years ago

While some of these are C++ headers, some are Hack, a language supported by HHVM. It's very similar to PHP.

Files recognized by HHVM will start with <?hh

Example: https://github.com/fredemmott/hh_extension_toolset/blob/master/src_classmap/Foo/Bar/Baz.hh

pchaigno commented 10 years ago

There is no Hack lexer in Pygments... You'll need to request one first, as Pygments is the syntax highlighter for linguist.

arfon commented 9 years ago

This should have been fixed in https://github.com/github/linguist/pull/1669

staabm commented 9 years ago

Created a pygments issue, https://bitbucket.org/birkenfeld/pygments-main/issue/1071/add-support-for-hack-files

arfon commented 9 years ago

Hey @staabm - this isn't a Pygments thing: https://github.com/github/linguist/pull/1669#issuecomment-68524699 (although if Pygments doesn't support Hack then it should :smile: - it's just not the problem here)

staabm commented 9 years ago

Hey! Thx for the info. It wont hurt in case they add support for it ;).