search

github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.29k stars 4.25k forks source link

Repositories that use the .inc extension are erroneously labeled as Assembly #1336

Closed CrimsonTautology closed 10 years ago

CrimsonTautology commented 10 years ago

The .inc extension is used for other languages aside from Assembly. Pull request #1268 has had the side effect of marking repositories that use these files as Assembly. I was told before that the .inc extension should not be used in the languages.yml file because it was too common but perhaps this has changed?

pchaigno commented 10 years ago

The .inc extension is used for other languages aside from Assembly.

Thanks for your feedback. Could you provide some examples of repositories impacted by this?

CrimsonTautology commented 10 years ago

One of my sourcepawn projects has this problem: https://github.com/CrimsonTautology/sm_in_game_audio

PHP also uses the .inc extension; here's a random repository I found that is impacted by this. https://github.com/broekhuisgavin/voorwaarts10-nl

pchaigno commented 10 years ago

We are currently waiting for a new test system to make any big changes in linguist. It will allow us to see the impact of a pull request on a subset of GitHub repositories. I'll make a PR to add the .inc extension for PHP when it's ready.

As for SourcePawn, is .inc a common extension?

ElliotFriend commented 10 years ago

One of mine looks like it has been impacted, too: https://github.com/stlchristian/slccweb

CrimsonTautology commented 10 years ago

As for SourcePawn, is .inc a common extension?

Yes, it's used for include files.

arfon commented 10 years ago

Thanks for bringing this to our attention @CrimsonTautology - this should be fixed now.