search

github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.34k stars 4.27k forks source link

(TextMate grammar included) eC syntax highlighting lost when switching from Pygments to TextMate #2068

Closed jerstlouis closed 9 years ago

jerstlouis commented 9 years ago

We've lost eC highlighting.

You can find an eC grammar for TextMate in this repository:

http://github.com/ecere/ec.tmbundle

Thank you.

Jerome

arfon commented 9 years ago

Thanks for reporting this @jerstlouis. We'll need the grammar to be licensed before we can consider including it in Linguist. I've opened an issue here: https://github.com/ecere/ec.tmbundle/issues/1

pchaigno commented 9 years ago

@arfon I'm making a second round for grammars (a lot of people responded to my issues for licenses quicker than I expected), I'll include this one.

arfon commented 9 years ago

:+1: awesome. Thanks @pchaigno

pchaigno commented 9 years ago

Never mind, there's still an issue: convert-grammars doesn't recognize the .tmGrammar extension. I've never seen it before so I don't know if we should add it to convert-grammar or not?

/cc @aroben

aroben commented 9 years ago

Does .tmGrammar work in TextMate? If so, let's change convert-grammars. If not, let's change ec.tmbundle to use a standard extension.

jerstlouis commented 9 years ago

I was told by Allan Odgaard that .plist was the old extension and now they use .tmGrammar

[10:31] also, name it eC.tmGrammar [10:31] the plist extension is deprecated

On Mon, Feb 2, 2015 at 2:25 PM, Adam Roben notifications@github.com wrote:

Does .tmGrammar work in TextMate? If so, let's change convert-grammars. If not, let's change ec.tmbundle to use a standard extension.

— Reply to this email directly or view it on GitHub https://github.com/github/linguist/issues/2068#issuecomment-72520123.

pchaigno commented 9 years ago

Does .tmGrammar work in TextMate? If so, let's change convert-grammars. If not, let's change ec.tmbundle to use a standard extension.

:+1: I don't have TextMate though

aroben commented 9 years ago

Weird, most bundles I've seen use .tmLanguage. I've never seen .tmGrammar, and there doesn't seem to be any code on GitHub using that extension either: https://github.com/search?utf8=✓&q=plist+extension%3AtmGrammar&ref=simplesearch

jerstlouis commented 9 years ago

Maybe he had a long day and meant .tmLanguage then? I don't mind either way :)

On Mon, Feb 2, 2015 at 4:28 PM, Adam Roben notifications@github.com wrote:

Weird, most bundles I've seen use .tmLanguage. I've never seen .tmGrammar, and there doesn't seem to be any code on GitHub using that extension either: https://github.com/search?utf8=✓&q=plist+extension%3AtmGrammar&ref=simplesearch https://github.com/search?utf8=%E2%9C%93&q=plist+extension%3AtmGrammar&ref=simplesearch

— Reply to this email directly or view it on GitHub https://github.com/github/linguist/issues/2068#issuecomment-72541505.

jerstlouis commented 9 years ago

Got the confirmation it should be .tmLanguage and fixed and pushed to

https://github.com/ecere/ec.tmbundle

On Mon, Feb 2, 2015 at 5:46 PM, Jerome St-Louis jerstlouis@gmail.com wrote:

Maybe he had a long day and meant .tmLanguage then? I don't mind either way :)

On Mon, Feb 2, 2015 at 4:28 PM, Adam Roben notifications@github.com wrote:

Weird, most bundles I've seen use .tmLanguage. I've never seen .tmGrammar, and there doesn't seem to be any code on GitHub using that extension either: https://github.com/search?utf8=✓&q=plist+extension%3AtmGrammar&ref=simplesearch https://github.com/search?utf8=%E2%9C%93&q=plist+extension%3AtmGrammar&ref=simplesearch

— Reply to this email directly or view it on GitHub https://github.com/github/linguist/issues/2068#issuecomment-72541505.

pchaigno commented 9 years ago

I added it to #2071.

arfon commented 9 years ago

:+1: - this should now be fixed in the latest release.