github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.28k stars 4.25k forks source link

Add .odd extension #2238

Closed joewiz closed 9 years ago

joewiz commented 9 years ago

There are nearly 500 ODD files in GitHub. ODD is an XML-based vocabulary for defining schemas for Text Encoding Initiative (TEI) projects, used widely in the humanities. ODD should be rendered using XML syntax but is currently displayed as plain text (see this example).

I would be happy to submit a pull request, but I'm not sure about whether to define .odd as an entry within the existing XML languages or whether I should submit this as a new language, along the lines of the entry for XProc. I'm inclined toward the former, but I'd appreciate guidance before I submit the wrong type of pull request.

Thanks in advance.

phase commented 9 years ago

I think you could add it to XML language if they're the same thing.

pchaigno commented 9 years ago

You could define it as a new language in Linguist if you wanted it to be counted as a different language (from XML) in the statistics or if you wanted to use a different grammar for highlighting. XML isn't counted in the statistics anyway, so, in your case, I think you should define it as a new extension.

Though 500 files might not be enough to add it to linguist (@arfon ?).

arfon commented 9 years ago

You could define it as a new language in Linguist if you wanted it to be counted as a different language (from XML) in the statistics or if you wanted to use a different grammar for highlighting. XML isn't counted in the statistics anyway, so, in your case, I think you should define it as a new extension.

Yes, I think we should add this as a new extension to XML. @joewiz - would you mind doing this? You can read our contributing guidelines here

joewiz commented 9 years ago

Sure, will do. Thanks for your guidance, everyone!