github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.29k stars 4.25k forks source link

Find grammars to replace those removed in #2884 #2885

Closed arfon closed 8 years ago

arfon commented 8 years ago

We've recently had to remove some language grammars (#2884). Ideally we need to find replacement grammars that are compatible with our license whitelist or encourage authors of the (currently removed) grammars to dual-license them.

arfon commented 8 years ago

Possible Assembly replacement: https://github.com/calculuswhiz/Assembly-Syntax-Definition

pchaigno commented 8 years ago

Why were https://github.com/nanoant/assembly.tmbundle and https://github.com/idleberg/InnoSetup-Sublime-Text removed? They seem to be under MIT license :/

arfon commented 8 years ago

Why were https://github.com/nanoant/assembly.tmbundle and https://github.com/idleberg/InnoSetup-Sublime-Text removed? They seem to be under MIT license :/

Good catch. I'll add those back. Not sure why I removed those...

vcunat commented 8 years ago

What's wrong with grammars under non-permissive licenses? In README you state:

The language grammars included in this gem are covered by their repositories' respective licenses.

I'm no lawyer, but it seems the worst thing that could happen when using linguist with (say) a GPL-licensed grammar is that together the license would be GPL. Why not keep that as an option, at least?

arfon commented 8 years ago

@vcunat - non-permissive licenses aren't compatible with the ways in which Linguist is distribute so we need all included grammars to have a permissive license I'm afraid.

vcunat commented 8 years ago

I see.

copumpkin commented 8 years ago

@arfon looks like @wmertens moved the nix highlighter to MIT. Can we get it reinstated on the live site? I use GitHub to browse Nix files a lot and it makes a big difference.

arfon commented 8 years ago

Yep. I will get to this early next week. We need to cut a new gem and deploy before this can be re-instated.

copumpkin commented 8 years ago

Thanks!

arfon commented 8 years ago

@copumpkin @wmertens #2914 is now live on GitHub.

copumpkin commented 8 years ago

@arfon @wmertens awesome, thank you both for dealing with this so quickly! The Nix community thanks you :smile:

arfon commented 8 years ago

@arfon @wmertens awesome, thank you both for dealing with this so quickly! The Nix community thanks you :smile:

👍 my pleasure, sorry for the disruption.

arfon commented 8 years ago

We've done pretty well here. Closing this out for now.