github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.14k stars 4.2k forks source link

Lightshow unable to parse CSON grammars with unquoted keys #2924

Closed Alhadis closed 6 years ago

Alhadis commented 8 years ago

Lightshow complains if a CSON/JSON grammar uses unquoted property names... presumably because it's mistaken it as YAML source:

Error parsing YAML grammar: (): did not find expected ',' or '}' while parsing a flow mapping at line 4 column 12

If quote marks are added, the problem goes away.

(I understand the Lightshow app is closed source, which is why I'm filing an issue instead of submitting a pull request...)

arfon commented 8 years ago

(I understand the Lightshow app is closed source, which is why I'm filing an issue instead of submitting a pull request...)

I believe this may be a short-term issue.

/ cc @aroben

pchaigno commented 8 years ago

This issue was reported before in #2703 ;)

Alhadis commented 8 years ago

Strange, that didn't turn up in the search results. :S Sorry.

pchaigno commented 8 years ago

@Alhadis No problem :-)

lildude commented 6 years ago

Lightshow complains if a CSON/JSON grammar uses unquoted property names... presumably because it's mistaken it as YAML source:

Error parsing YAML grammar: (): did not find expected ',' or '}' while parsing a flow mapping at line 4 column 12

Not anymore 😄 and if it still gets it wrong from attempting to auto-detect the format, you can manually select the format of the grammar.