github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.26k stars 4.24k forks source link

Add language PowerBuilder #3014

Closed krahllucas closed 8 years ago

krahllucas commented 8 years ago

Hi guys,

We have a couple of PowerBuilder projects. And don't have that language in this project. We would like to contribute by providing this change.

Thanks, Lucas.

pchaigno commented 8 years ago

Hi @LucasKrahl23! Please take a look at the requirements (and steps involved) to add support for a language to Linguist. If the language meets the requirements, a pull request would definitively be welcome!

sahildua2305 commented 8 years ago

@arfon @pchaigno Is it confirmed that PowerBuilder can be added or do I need to check if that meets the requirements or not?

arfon commented 8 years ago

@arfon @pchaigno Is it confirmed that PowerBuilder can be added or do I need to check if that meets the requirements or not?

It is not. Assessing whether PowerBuilder meets the requirements outlined here is probably the next step.

sahildua2305 commented 8 years ago

@arfon I have found that PowerBuilder (PB) is an Object Oriented, Event Driven environment that used its own language, called PowerScript. The possible file extensions can be PBL, PDB, PBW, PBT, SRD, SRW, SRM, SRU, SRS, SRP, SRF, SRQ, SRA and SRJ.

While searching for powerscript gives a lot of results which contain files with these extensions, searching for these extensions separately doesn't generate any results.

nixel2007 commented 8 years ago

@sahildua2305

searching for these extensions separately doesn't generate any results.

you need to search any key. common practice is search by NOT nothack extension:your_extension query

sahildua2305 commented 8 years ago

Thanks @nixel2007

@arfon I have found these results:

Cumulative results for all these extensions - 2,387,000 results

nixel2007 commented 8 years ago

Are all of this extensions text-based? dll (PDB) used to be binary

sahildua2305 commented 8 years ago

@nixel2007 PBL, PBT, SRW, SRU, SRP, SRA and SRJ extensions are mostly text-based.

PBW, SRD, SRM, SRS and SRF are sometimes text-based. :confused:

Yes, PDB isn't text based.

larsbrinkhoff commented 8 years ago

Also, .pdb is used for Visual Studio "program database" files.

https://msdn.microsoft.com/en-us/library/yd4f8bd1%28vs.71%29.aspx

(Edited.)

sahildua2305 commented 8 years ago

@larsbrinkhoff Yes, that's why I have excluded PDB extension from my above comment stating which of the extensions are text-based. :smile:

(Edited.)

larsbrinkhoff commented 8 years ago

Sorry, I edited my reply above.

sahildua2305 commented 8 years ago

@larsbrinkhoff Check my edited comment.

arfon commented 8 years ago

OK thanks @sahildua2305.

@nixel2007 PBL, PBT, SRW, SRU, SRP, SRA and SRJ extensions are mostly text-based.

I would suggest that we move this to a pull request at this stage implementing these extension. Many of the others I checked were binary which means we're never going to try and detect the language even if we define the extension.

sahildua2305 commented 8 years ago

Awesome @arfon ! I will submit a PR today itself.

sahildua2305 commented 8 years ago

@arfon Let's close this issue? :smile:

sahildua2305 commented 8 years ago

@arfon @pchaigno Can you please assign me some "low" or "medium" effort task? I'd love to keep contributing.