biell
commented
7 years ago Change #3735 needs to be rolled-back. If a file starts with "#!/usr/bin/perl", "#!/usr/bin/env perl", or anything similar, then it should be rendered as perl code, not as pod. Rendering as code is the correct decision 99% of the time when a shebang is present, and so should be the default.
If you want to review the entire file and find no actual code, then you can render as pod. But, when in doubt, render as code when a shebang is present. This bug affects hundreds of repositories; including, but not limited to:
- https://github.com/libwww-perl/libwww-perl
- https://github.com/rurban/perl-compiler
- https://github.com/oetiker/mrtg
- https://github.com/briandfoy/PerlPowerTools
- https://github.com/duckduckgo/duckduckgo-publisher
- https://github.com/neilb/Module-Path
- https://github.com/SUSE/smt
- https://github.com/hachi/Perlbal
- https://github.com/skx/sysadmin-util
- https://github.com/kraih/mojo
- https://github.com/duckduckgo/p5-app-duckpan
- https://github.com/jmcnamara/excel-writer-xlsx
- https://github.com/neilb/Net-Dict
- https://github.com/preaction/Statocles
- https://github.com/gugod/App-perlbrew
- https://github.com/skx/templer
- https://github.com/kasei/perlrdf
- https://github.com/briandfoy/Unicode-Tussle
- https://github.com/PerlDancer/Dancer2
- https://github.com/briandfoy/git-github-creator
- https://github.com/pssc/squeezy
- https://github.com/soarpenguin/perl-scripts
- https://github.com/msimerson/mail-dmarc
- https://github.com/abw/Template2
- https://github.com/bruceravel/demeter
- https://github.com/davorg/perlanet
- https://github.com/nichtich/Pandoc-Elements
- https://github.com/pjlsergeant/test-bdd-cucumber-perl
- https://github.com/beanz/xpl-perl
- https://github.com/skx/markdownshare.com
- https://github.com/Starlink/ORAC-DR
- https://github.com/PerlDancer/Dancer
- https://github.com/fusioninventory/fusioninventory-agent
- https://github.com/beyondgrep/ack3
- ...
ascherer
lildude
omkensey
kivikakk
dgholz
This bug was introduced in #3735. Here's an expanded version of my comment from there.
This change recognizes files with no extension and a perl shebang and POD contents as POD files, but I'd expect them to be shown as syntax-highlighted perl. I would expect POD-only files to (maybe) have a
.podextension, and (always) no shebang. Some examples from CPAN:https://metacpan.org/source/LEONT/Module-Build-0.4224/lib/Module/Build/API.pod has no shebang and a
.podextension.https://metacpan.org/source/LEONT/Module-Build-0.4224/lib/Module/Build/Cookbook.pm has no shebang and a
.pmextension.Here's an example of where linguist chooses to render as POD rather than as syntax-highlighted perl: https://github.com/sitaramc/gitolite/blob/5c2fe87019dadbecb1883bedd075cd07b07b2078/src/gitolite It previously displayed as a highlighted perl script (good), but now displays as the embedded POD (requiring me to use the Raw view to be able to see the code). It has a shebang.
Please fix it to correctly detect these kinds of files as perl (not POD) or revert it, thanks!