search

github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.27k stars 4.24k forks source link

Issue: Linguist not being running when accepting a pull request #4276

Closed pulimento closed 6 years ago

pulimento commented 6 years ago

Preliminary Steps

Please confirm you have...

Problem Description

It totally seems that linguist is not running when accepting a pull request (e.g. merging dev branch to master, from an opened pull request, from the web client). Reading how Linguist (and when) should run, I've pushed a manual silly commit, and now works fine. The problem is solved at the moment, but just before doing that newline commit, language reported was wrong. The accepted pull request deletes all HTML files. Before and after accepting this pull request, language was detected as HTML. Seeing that linguist didn't run, I created this commit, and it fixed the issue.

URL of the affected repository:

https://github.com/WaveEngine/Samples (not anymore an issue).

Last modified on:

Today, 28/09/2018

Expected language:

Mostly c#

Detected language:

(before last gitignore commit) Mostly HTML

pchaigno commented 6 years ago

Thanks for the report!

Do you remember how long you waited before pushing the "silly commit"?

lildude commented 6 years ago

For a start, this is not a Linguist problem (it's technically a jobs problem on GitHub.com, if it were a problem), and secondly, this can happen and is documented in the README…

How Linguist works on GitHub.com

When you push changes to a repository on GitHub.com, a low priority background job is enqueued to analyze your repository as explained above. The results of this analysis are cached for the lifetime of your repository and are only updated when the repository is updated. As this analysis is performed by a low priority background job, it can take a while, particularly during busy periods, for your language statistics bar to reflect your changes.

If you left it long enough after the merge, you should have seen your language stats updated to reflect the changes. It's very likely your "silly commit" coincided with the running of the background job from the earlier merge.

If you can readily reproduce this and don't see your language stats updating after a few hours (excessive but ensures the job should definitely have run), please contact GitHub support.

pulimento commented 6 years ago

About 12-15 hours

El vie., 28 sept. 2018 9:33, Paul Chaignon notifications@github.com escribió:

Thanks for the report!

Do you remember how long you waited before pushing the "silly commit"?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/github/linguist/issues/4276#issuecomment-425348695, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeuEdPXEK9SBDv3i4LM9hkrfNDcSMa1ks5ufdDDgaJpZM4W98ef .

lildude commented 6 years ago

Thanks. That should have been plenty of time, but does indicate a problem with the background job. As there's little we can do about it now, the best thing to do is contact GitHub support the next time you encounter the problem before making any changes that could hide the state.

pulimento commented 6 years ago

Ok, thanks to both of you. You're right, this is not an issue with the tool itself, but with GitHub jobs. I'm closing the issue now.

@lildude Yes, only I was aware of the problem when it was fixed. @pchaigno Even on a low-priority queue, more than 12 hours should be enough. Don't think of a coincidence, but nevermind anyway.

Again, thanks. Hace a nice day