github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
11.95k stars 4.14k forks source link

Add `RPG Maker MV` to the list. #5403

Closed wg481 closed 3 years ago

wg481 commented 3 years ago

Describe the enhancement

RPG Maker MV (technically MZ as well) should be added to the list.
I know it's not that big of a platform, but I think it would be nice. I would add it just as RPG Maker with the type being data. In the lineup, it would place directly after Ruby.

Supported filetypes exclusive to RPG Maker MV/MZ are:

For adding the RPG Maker tool series as a whole, and not under specific versions, include filetypes like:

It would be helpful for identifying projects rather than using OTHER as in the linguist section.

Nixinova commented 3 years ago

They look like binary files; Linguist only covers source (text-based) files and those extensions don't seem to be in use

wg481 commented 3 years ago

From what languages.yml looks to be, it's a simple structure that detects file extensions.

Nixinova commented 3 years ago

It detects languages, not file extensions. If any of these are written in an actual language they can be added but if they are binary files (i.e. if you open one it's gibberish) they arent covered by this.

lildude commented 3 years ago

Linguist would never get to reading the languages.yml file thanks to this very early guard:

https://github.com/github/linguist/blob/757b173b34db14bc23c7b53a15252628add4f815/lib/linguist.rb#L22

So even if we added binary extensions, repos would never show a language for them rendering most (all?) of the implantation PR useless.