github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.15k stars 4.21k forks source link

Replace old Cairo 0.x samples with Cairo 2.6.x ones #6878

Closed mkaput closed 3 months ago

mkaput commented 3 months ago

Description

The samples in this repository are written in now-abandoned Cairo 0.x. Cairo 1.0 was a complete redoing of the language, and old code is completely incompatible with it.

This PR removes them and adds new ones that are written in current Cairo 2.6.4. These samples were taken from real repositories: one is an excerpt from the Cairo standard library, and two are listings from the Cairo Book. I have added source and license attributions in comments.

Note that we have recently created an official tree sitter grammar for Cairo. We are also planning to make a TextMate grammar to use in our VSCode extension (https://github.com/starkware-libs/cairo/issues/5776), so I will wait for it to happen, and I'll open a separate PR here that will update the grammar.

Checklist:

lildude commented 3 months ago

If the language is completely different and incompatible and the grammar doesn't support both versions of the language, a new language entry should be created and grouped with the old.

Closing as we never remove a language or their valid at the time samples as old code always exists.

mkaput commented 3 months ago

Ok, I'll submit these samples together with the new grammar.