search

github-linguist / linguist

Language Savant. If your repository's language is being reported incorrectly, send us a pull request!
MIT License
12.15k stars 4.21k forks source link

Deno Lockfiles #6882

Closed lishaduck closed 1 month ago

lishaduck commented 3 months ago

Describe the enhancement

I noticed that deno.lock isn't marked as generated. As I looked at the source code for marking things as generated, I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock? Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

lildude commented 3 months ago

I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock?

Yes, because not everyone wants their lock files marked as generated as is the case with yarn.lock following the discussion in https://github.com/github-linguist/linguist/issues/4348

Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

We're happy to accept a PR, but keep in mind the yarn community's decision; maybe the demo community expects the same?

lishaduck commented 3 months ago

I wondered if there's a reason for individualizing marking each ecosystem? Given that .lock feels pretty standard now, would it be possible to autodetect any lockfile, including deno.lock?

Yes, because not everyone wants their lock files marked as generated as is the case with yarn.lock following the discussion in #4348

Ah, yes. I recall seeing that. That makes a lot more sense now.

Alternatively, could y'all add deno.lock/would y'all be open to contributions for it?

We're happy to accept a PR, but keep in mind the yarn community's decision; maybe the demo community expects the same?

Given the differences between PnP and HTTPS imports, and particularly that much of the ecosystem doesn't use lockfiles (as esm.sh messes them up), I don't think that Yarn's security argument applies here.