search

github-modules / pull-request-modules

a list of javascript modules for managing pull requests
14 stars 3 forks source link

[Inquiry] Regex-based PR Bot #1

Open dawsbot opened 7 years ago

dawsbot commented 7 years ago

Hey @zeke and others,

Looking for a bot that would perform a regex check on a predictable file (yarn.lock) and reject the PR if that regex matches. Seems like a good general-purpose bot people could use. Ruby's Danger could potentially cover this use case, but do you know of an existing solution for this use case that's node-based? Or perhaps generically bash-based even.

zeke commented 7 years ago

Maybe https://github.com/probot ?

cc @bkeepers @lee-dohm

lee-dohm commented 7 years ago

@dawsbot Probot could definitely cover this kind of thing and is Node-based. You might even want to take a look at our probot/DCO repo for an example of something similar.

bkeepers commented 7 years ago

probot/dco, which checks that all commits in a PR have the Signed-off-by line in the commit message, could be used as an example starting point for this.

Specifically check out: https://github.com/probot/dco/blob/master/index.js#L20-L35

bkeepers commented 7 years ago

Doh, sorry @lee-dohm, your comment didn't show up for me until after I posted.