github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

Closed issues under current tag are not included while generating release notes #192

Open sravan09 opened 5 years ago

sravan09 commented 5 years ago

Not able to include issues closed under current tag in release notes. They get copied into next release notes.

alexcanessa commented 5 years ago

Hey! Thanks for the feedback. Is this a duplication of #181?

sravan09 commented 5 years ago

Yes. This looks similar

hbenbenishti commented 5 years ago

Hey, Same issue for us. Is there any estimation when it will be handled please? From our point of view it looks like it is a critical issue for GREN, since it does not fulfil its main goal with this problem.

chenfli commented 5 years ago

The fix is quite simple, https://github.com/github-tools/github-release-notes/blob/0a63afc2f2b54a76bdf99f586bb3c01d46435198/lib/src/Gren.js#L908 should be removed. That is the problem

aldo-sorbara commented 5 years ago

Hi, same issue here, is there any estimation when it will be handled? Thanks