github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

Pass user.login and user.html_url into issue templating method #202

Closed fthomas closed 5 years ago

fthomas commented 5 years ago

Closes #201

This makes user_login and user_url variables available to the issue template.

codecov-io commented 5 years ago

Codecov Report

Merging #202 into master will decrease coverage by 45.79%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   84.19%   38.39%   -45.8%     
==========================================
  Files           8        8              
  Lines         348      349       +1     
==========================================
- Hits          293      134     -159     
- Misses         55      215     +160
Impacted Files Coverage Δ
lib/src/Gren.js 5.26% <ø> (-76.08%) :arrow_down:
lib/src/GitHubInfo.js 80.95% <0%> (-4.77%) :arrow_down:
lib/src/_utils.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a63afc...7052ef6. Read the comment docs.

fthomas commented 5 years ago

I tried this change here: https://github.com/fthomas/scala-steward/commit/1e754eb76a338d1071299028cd4ee30d75bbf27a Works fine for me.

yogevbd commented 5 years ago

@alexcanessa Can you guys please release a new version with this change? Thanks

alexcanessa commented 4 years ago

@all-contributors please add @fthomas for code

allcontributors[bot] commented 4 years ago

@alexcanessa

I've put up a pull request to add @fthomas! :tada: