github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

Provide commit sha to start history with #207

Closed masim05 closed 5 years ago

masim05 commented 5 years ago

Closes #206

Current high level logic of gren.js release --data-source=commits is:

As a result, the following workflow is problematic (release notes are empty):

One option to fix it is to provide sha to start history with. Currently it is not provided so default master is always used.

codecov-io commented 5 years ago

Codecov Report

Merging #207 into master will decrease coverage by 45.84%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #207       +/-   ##
===========================================
- Coverage   84.24%   38.39%   -45.85%     
===========================================
  Files           8        8               
  Lines         349      349               
===========================================
- Hits          294      134      -160     
- Misses         55      215      +160
Impacted Files Coverage Δ
lib/src/Gren.js 5.26% <0%> (-76.08%) :arrow_down:
lib/src/GitHubInfo.js 80.95% <0%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab8305f...d6a8d6f. Read the comment docs.