search

github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

Limits the issue list to 30 while generating release notes #209

Open amit-mhetre opened 5 years ago

amit-mhetre commented 5 years ago

When I try to generate release notes which has issues more than 30, it ignores the the issues after 30th issue. Below is the logs I am getting while generating relase notes.

🤖  - Generate release notes:
===================================
✔ Releases found: 1
✔ Tags found: v1.0, starting_v1.0_implementation
✔ Issues found: 30

May I know, how we can change the count of issues to be consider while generating notes.

SamuelHassine commented 5 years ago

Hello,

I have the same problem and it seems to be linked to the Github rate limit, anyone has a solution?

Thanks!

omerlh commented 5 years ago

I think this is the root issue: github-tools/github#569. I was managed to bypass this issue by requesting more items. Change this line to add the maximum items per page (as documented here):

        const { data: issues } = await this.issues.listIssues({
            state: 'closed',
            since: releaseRanges[releaseRanges.length - 1][1].date,
            per_page: 100
        });
amit-mhetre commented 5 years ago 
per_page: 100

Thanks @omerlh This solution worked for me. But I think it doesn't fetch the issues more than 100 even though we set the number which is greater than 100. Do you have any idea about this? Once again thanks!

omerlh commented 5 years ago

Yep, 100 is the limit :(