search

github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

Issue does not show on release notes after it was reopened then closed #223

Closed ipolevoy closed 4 years ago

ipolevoy commented 4 years ago

Here is the chain of events:

  1. Generated release notes: https://github.com/javalite/javalite/releases/tag/javalite-2.3.1-j8 with commmand:

gren release -t javalite-2.3.1-j8 activejdbc-root-2.3 --override

The issue https://github.com/javalite/javalite/issues/913 is on the release notes.

  1. Reopened https://github.com/javalite/javalite/issues/913 to not forget to document a new feature.

  2. Regenerate release notes with the same command. The issue is now gone from release notes.

  3. Closed the issue and regenerated release notes again, but the issue is no longer on the list.

My config file: 

---
  dataSource: "issues"
  prefix: ""
  ignoreIssuesWith: 
    - "In-Progress"
    - "Priority-High"
    - "Priority-Low"
    - "Priority-Medium"
    - "Rejected"
    - "Type-Review"
    - "bug"
    - "duplicate"
    - "enhancement"
    - "imported"
    - "question"
  onlyMilestones: false
  groupBy: false
#      ActiveJDBC:
#        - "Module: ActiveJDBC"
#      ActiveWeb:
#          - "Module: ActiveWeb"

  changelogFilename: "CHANGELOG.md"

Is there a flag I can use to bring the reopened then closed issues back or this is a bug?

ipolevoy commented 4 years ago

anyone?

alexcanessa commented 4 years ago

Hello @ipolevoy ,

gren looks at when the issue has been closed and if it's in between two tag dates. This means that to include it you should tag again (in theory)