github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

feat: support rc file from npm package #252

Open donaldshen opened 4 years ago

donaldshen commented 4 years ago

Why

Sometimes we want to share the same .grenrc.js among many projects, and manage it using npm package, just like what prettier did. This is a job finishing pr #230 .

How

  1. treat gren as npm package name if it does not start with 'http'
  2. use npm's api to get the latest package version a. use require(child_process).spawnSync so that async operation could act like sync operation in main process
  3. use jsdelivr to get the config file

Test

alexcanessa commented 4 years ago

@donaldshen that's great! thanks.

The only thing is that we should probably have a mock for the remote configuration or at least a @gren/recommended sort of thing that at this point we should have.