github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
880 stars 325 forks source link

All tags in each release instead only commits between tags #279

Open papanito opened 4 years ago

papanito commented 4 years ago

I want to generate the changelog for all releases I have running this

gren changelog --generate --data-source commits --tags=all --override --token $GITHUB_TOKEN

I would expect that each version (tag) contains the commits between old tag and the current one. However, I see each commit from for all releases

# Changelog

## v1.0.5-pre (01/01/1970)
- [Create FUNDING.yml](https://github.com/papanito/ansible-role-cloudflared/commit/a9a2a469bb6c7318f64dc04b5f2b851135f76881) - @papanito
- [Update documentation](https://github.com/papanito/ansible-role-cloudflared/commit/0401a2497a7dd22d4d99212ddc3945899d74385c) - @papanito
- [`install_only` will only install, not login, not configure anything](https://github.com/papanito/ansible-role-cloudflared/commit/0ea48ebdcea079a5d196f1c25f01a42b629e4251) - @papanito
- [Fix: Copy cert only if defined](https://github.com/papanito/ansible-role-cloudflared/commit/58512aac3b75c554f0b6e97be2cb73b661580d8c) - @papanito
- [Remove become as part of the role, leave this to user](https://github.com/papanito/ansible-role-cloudflared/commit/1c5b261b89f228fd4939026dd53d569b502266a0) - @papanito
- [Correct issue_tracker_url](https://github.com/papanito/ansible-role-cloudflared/commit/acf4312f085384aaf2851c8d43eea802c4d98d71) - @papanito
- [Fix some bugs. role work properly now](https://github.com/papanito/ansible-role-cloudflared/commit/ccfa40f24c49dcd2600622804e84b2e62837224f) - @papanito
- [[ci] Enable ansible syntax-check](https://github.com/papanito/ansible-role-cloudflared/commit/7c2ad3a2b629024f3bf1f835d633c942adade15f) - @papanito
- [Update README.md](https://github.com/papanito/ansible-role-cloudflared/commit/2154b8cc2316d2c2b269cd3ea9c30ee721737a52) - @papanito
- [[ci] Ensure import-role runs after build](https://github.com/papanito/ansible-role-cloudflared/commit/04c11c47cbeedbb36181d80f931f2974bb8c7048) - @papanito
- [[¢i] Add import-role stage](https://github.com/papanito/ansible-role-cloudflared/commit/22ccbebdee8120d0b4a3e43f1f1dea7cbf961192) - @papanito
- [Disable ansible syntax-check](https://github.com/papanito/ansible-role-cloudflared/commit/06f4027d298cdcf06d05f0a8410767af937e7239) - @papanito
- [[ci] Create github action workflow, remove .travis.yml](https://github.com/papanito/ansible-role-cloudflared/commit/7835d6d65421bc5a110fc036d1983de8928ed675) - @papanito

---

## v1.0.4 (01/01/1970)
- [Create FUNDING.yml](https://github.com/papanito/ansible-role-cloudflared/commit/a9a2a469bb6c7318f64dc04b5f2b851135f76881) - @papanito
- [Update documentation](https://github.com/papanito/ansible-role-cloudflared/commit/0401a2497a7dd22d4d99212ddc3945899d74385c) - @papanito
- [`install_only` will only install, not login, not configure anything](https://github.com/papanito/ansible-role-cloudflared/commit/0ea48ebdcea079a5d196f1c25f01a42b629e4251) - @papanito
- [Fix: Copy cert only if defined](https://github.com/papanito/ansible-role-cloudflared/commit/58512aac3b75c554f0b6e97be2cb73b661580d8c) - @papanito
- [Remove become as part of the role, leave this to user](https://github.com/papanito/ansible-role-cloudflared/commit/1c5b261b89f228fd4939026dd53d569b502266a0) - @papanito
- [Correct issue_tracker_url](https://github.com/papanito/ansible-role-cloudflared/commit/acf4312f085384aaf2851c8d43eea802c4d98d71) - @papanito
- [Fix some bugs. role work properly now](https://github.com/papanito/ansible-role-cloudflared/commit/ccfa40f24c49dcd2600622804e84b2e62837224f) - @papanito
- [[ci] Enable ansible syntax-check](https://github.com/papanito/ansible-role-cloudflared/commit/7c2ad3a2b629024f3bf1f835d633c942adade15f) - @papanito
- [Update README.md](https://github.com/papanito/ansible-role-cloudflared/commit/2154b8cc2316d2c2b269cd3ea9c30ee721737a52) - @papanito
- [[ci] Ensure import-role runs after build](https://github.com/papanito/ansible-role-cloudflared/commit/04c11c47cbeedbb36181d80f931f2974bb8c7048) - @papanito
- [[¢i] Add import-role stage](https://github.com/papanito/ansible-role-cloudflared/commit/22ccbebdee8120d0b4a3e43f1f1dea7cbf961192) - @papanito
- [Disable ansible syntax-check](https://github.com/papanito/ansible-role-cloudflared/commit/06f4027d298cdcf06d05f0a8410767af937e7239) - @papanito
- [[ci] Create github action workflow, remove .travis.yml](https://github.com/papanito/ansible-role-cloudflared/commit/7835d6d65421bc5a110fc036d1983de8928ed675) - @papanito
....
---

This is the git log

a9a2a46 (HEAD -> master, origin/master) Create FUNDING.yml
0401a24 Update documentation
0ea48eb (tag: v1.0.4) `install_only` will only install, not login, not configure anything
58512aa (tag: v1.0.3) Fix: Copy cert only if defined
1c5b261 (tag: v1.0.2) Remove become as part of the role, leave this to user
acf4312 Correct issue_tracker_url
ccfa40f (tag: v1.0.1) Fix some bugs. role work properly now
7c2ad3a [ci] Enable ansible syntax-check
2154b8c Update README.md
04c11c4 [ci] Ensure import-role runs after build
22ccbeb [¢i] Add import-role stage
06f4027 Disable ansible syntax-check
7835d6d [ci] Create github action workflow, remove .travis.yml
54ceeda (tag: v1.0.0) Initial commit

Version: 0.17.3

robert-lacagnina commented 4 years ago

Yeah I'll add to this. I've seen similar behavior on 0.17.3. I tried to generate release notes between two specific tags which only have about 3 commits and I got all my commits listed in the changelog. Downgrading to 0.17.2 resolved the issue and I saw only commits between tags as expected.

snahelou commented 4 years ago

Same problem for me. Using 0.17.1 solved the problem too.

cjbarth commented 2 years ago

@airshipbot, @v1v I believe the changes I've made in my fork correct for this problem. Please let me know if they don't. https://github.com/cjbarth/github-release-notes/releases/tag/0.18.0