search

github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
883 stars 324 forks source link

fix: index out of range bug #289

Closed HarikrishnanBalagopal closed 3 years ago

HarikrishnanBalagopal commented 3 years ago

The for loop condition needs to depend on the RANGE, otherwise it the index will go out of range when we access i + RANGE - 1 inside the for loop.

Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com

Fixes #288

codecov-io commented 3 years ago

Codecov Report

Merging #289 (12eed89) into master (d7ad51a) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   39.08%   39.08%           
=======================================
  Files           8        8           
  Lines         394      394           
=======================================
  Hits          154      154           
  Misses        240      240
Impacted Files Coverage Δ
lib/src/Gren.js 4.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c5affc...12eed89. Read the comment docs.