github-tools / github-release-notes

Node module to create a release or a changelog from a tag and uses issues or commits to creating the release notes.
https://github-tools.github.io/github-release-notes/
GNU General Public License v3.0
880 stars 325 forks source link

`gren changelog` not finding all releases #308

Open paul-uz opened 2 years ago

paul-uz commented 2 years ago

I have a private repo with 40+ releases, but running gren changelog only finds 30 releases.

All releases follow the same versioning format, x.y.z

paul-uz commented 2 years ago

I tried with --limit 100 but the debug info still says 30

gren changelog -o -D prs --limit 100 -B

Options: 
Tags: empty
Prefix: empty
Template: [object Object]
Prerelease: false
Generate: false
Quiet: false
Override: true
Debug: true
Ignore labels: empty
Ignore issues with: empty
Ignore commits with: empty
Group by: false
Milestone match: Release {{tag_name}}
Changelog filename: CHANGELOG.md
Username: Foobar
Repo: XYZ
Token: XXX
Limit: 30
Data source: prs
Include messages: commits
Ignore tags with: empty
paul-uz commented 2 years ago

Limit does work, for numbers <= 99. As soon as you try 100, it defaults back to 30

mv-coder commented 2 years ago

That is, because there is a MAX_TAGS_LIMIT = 99 in https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js. If you go beyond that, it will revert to the default TAGS_LIMIT = 30.

paul-uz commented 2 years ago

Well, thats a bit daft isn't it. And not mentioned in the documentation 🙄