github-tools / github

A higher-level wrapper around the Github API. Intended for the browser.
BSD 3-Clause "New" or "Revised" License
3.59k stars 755 forks source link

Allow commit message author and committer on delete file action #526

Closed ekeren closed 1 year ago

ekeren commented 5 years ago

The commit message for file deletion is hardcoded, we would like to allow the same api as writeFile

The new signature should be: function deleteFile(branch, path, message, options, cb) instead of existing one: function deleteFile(branch, path, cb)

message, option - should be optional

We already have the code that fixes this issue in our code base, if this request is approved we can open a pull request.

Thanks in advanced

j-rewerts commented 5 years ago

Please submit this as a PR.