search

github-tools / github

A higher-level wrapper around the Github API. Intended for the browser.
BSD 3-Clause "New" or "Revised" License
3.59k stars 755 forks source link

Add commit author #547

Closed j-rewerts closed 5 years ago

j-rewerts commented 5 years ago

Closes #546.

The commit function can now accept optional parameters for setting who the author or committer is. See here for GitHub's API on it.

j-rewerts commented 5 years ago

If we merge #544 and #545, all the tests should pass.

j-rewerts commented 5 years ago

@clayreimann Do you want me to merge from upstream master into my branch prior to merging?

clayreimann commented 5 years ago

@j-rewerts merge or rebase is fine with me. My first instinct is to squash merge for small PRs with more than 1 commit.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@64a9223). Click here to learn what that means. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #547   +/-   ##
=========================================
  Coverage          ?   90.79%           
=========================================
  Files             ?       12           
  Lines             ?      413           
  Branches          ?        0           
=========================================
  Hits              ?      375           
  Misses            ?       38           
  Partials          ?        0
Impacted Files Coverage Δ
lib/Requestable.js 94.11% <ø> (ø)
lib/GitHub.js 100% <ø> (ø)
lib/Repository.js 81.3% <100%> (ø)
lib/User.js 94.73% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64a9223...d25bc31. Read the comment docs.

j-rewerts commented 5 years ago

@clayreimann Yeah feel free to squash and merge.