search

github-tools / github

A higher-level wrapper around the Github API. Intended for the browser.
BSD 3-Clause "New" or "Revised" License
3.6k stars 755 forks source link

fix(repository): prevents lib from crashing when not providing option… #588

Closed hazmah0 closed 4 years ago

hazmah0 commented 4 years ago

…al arguments

Ran into this issue today described in this old PR: https://github.com/github-tools/github/pull/456

This provides the same fix and adds a test case, though I can't run the tests since it asks me to email jaredrewerts@gmail.com to get access.

j-rewerts commented 4 years ago

Apologies for the delay @hazmah0. I've been traveling.

Please make the requested changes. As for the testing account, feel free to email me and I can get you access, or alternatively, feel free to use one of your own GitHub accounts. Just note that running the test suite will create and edit a bunch of things, so it's best to avoid using your primary account.

j-rewerts commented 4 years ago

Also, I'm not too sure how Hacktoberfest counts contributions, but if you need to close and reopen this to get it to count towards your 5, feel free to do that.

hazmah0 commented 4 years ago

No worries about the contribution count. I'll send an email later today, thanks!

j-rewerts commented 4 years ago

LGTM!

hazmah0 commented 4 years ago

Just noticed that the CI is failing the lint task due to a missing semicolon at line 395. I can submit a new PR with that fix later today!