search

github-tools / github

A higher-level wrapper around the Github API. Intended for the browser.
BSD 3-Clause "New" or "Revised" License
3.6k stars 755 forks source link

Code review contributions in Github #611

Closed AtomicNess123 closed 4 years ago

AtomicNess123 commented 4 years ago

This is a basic question, but... what counts as "code review" in the contribution graph in Github? Is it making comments on code or committing to code? I don't really understand the concept.

DanielRuf commented 4 years ago

Hi @Gahamelas,

It seems you confuse this repo (GitHub API client written in JavaScript) with the GitHub support but I try to answer your question.

Code review is when you go to a PR (pull request), go to the "Files changed" tab of it and provide feedback (approve, comment, request changes).

Bildschirmfoto 2020-06-06 um 12 17 27

As this has nothing to do with this client library I'm closing this issue.

AtomicNess123 commented 4 years ago

Thanks so much. At the cost of abusing your help... Even if you don't comment, just approve a PR, will that be counting as code review?

DanielRuf commented 4 years ago

Yes, approving a PR counts as code review.

IMG_20200607_175608

AtomicNess123 commented 4 years ago

Thank you!