search

github-vet / bots

Bots for running analysis on GitHub's public Go repositories and crowdsourcing their classification.
MIT License
1 stars 1 forks source link

Handle variadic functions #104

Open kalexmills opened 3 years ago

kalexmills commented 3 years ago

Right now, nothing is done in the callgraph (and therefore any of the analyzers) to consider variadic functions. This is a potential source of false-negatives.

EDIT: actually they may erroneously be reported as third-party functions when they shouldn't be. Changing the labels.

kalexmills commented 3 years ago

Can also cause false-positives in #109

kalexmills commented 3 years ago

I'm not okay with allowing the tool to misreport variadic functions. We can tag when a signature has a declaration with variadic arguments and include that suspicion in case we suspect it may be involved as a "third-party" function.

Also the "third-party" message should be rewritten to say "function whose declaration could not be tracked".