third-party reporting may not work with variadic functions

github-vet / bots

Bots for running analysis on GitHub's public Go repositories and crowdsourcing their classification.

MIT License

1 stars 1 forks source link

third-party reporting may not work with variadic functions #109

Open kalexmills opened 3 years ago

kalexmills commented 3 years ago

https://github.com/github-vet/rangeloop-pointer-findings/issues/8532 was erroneously marked as involving a 'third-party' fucnction despite its presence in the repository. It's quite possible the use of variadic functions is throwing things off. No idea how many arguments are expected in the signature that VetBot found.

kalexmills commented 3 years ago

Related to #104

kalexmills commented 3 years ago

This is a misreport in part because the error message is misleading. It should be corrected to state that the declaration could not be found.

So far, we know this happens when either the function was third party, variadic, or dynamic (i.e. function was stored and passed as a variable). The message should reflect that uncertainty.