search

github-vet / bots

Bots for running analysis on GitHub's public Go repositories and crowdsourcing their classification.
MIT License
1 stars 1 forks source link

fresh label applied and removed all at once. #96

Open kalexmills opened 3 years ago

kalexmills commented 3 years ago

image

^--- this is wrong

kalexmills commented 3 years ago

This is a race condition resulting from setting labels in two separate places and/or too much asynchrony in TrackBot.

The fresh label is removed at one point in the program. This results in an API call SetExpertLabel also makes a call to modify labels; by replacing the labels for the issue.

The correct thing to do is to track the current set of labels as the issue is processed and commit them only once at the end of processing.

kalexmills commented 3 years ago

No harm is really done here for the moment; it will only take one more pass for the labels to correct themselves.

Not going to label as wontfix, though, since there are technically too many precious, precious API calls being made.