github-vet / rangeloop-pointer-findings

Issue tracker collects instances of Go code on GitHub that make use of references to range loop variables.
0 stars 0 forks source link

akraino-edge-stack/icn-sdwan: platform/crd-ctrlr/src/controllers/sdewanapplication_controller.go; 23 LoC #18428

Open githubvet opened 3 years ago

githubvet commented 3 years ago

Found a possible issue in akraino-edge-stack/icn-sdwan at platform/crd-ctrlr/src/controllers/sdewanapplication_controller.go

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

reference to appCR is reassigned at line 188

Click here to see the code in its original context.

Click here to show the 23 line(s) of Go which triggered the analyzer. ```go for _, appCR := range appCRList.Items { ps := appCR.Spec.PodSelector.MatchLabels ns := appCR.Spec.AppNamespace judge := true if ns != podNamespace { judge = false } else { for key, value := range ps { if _, ok := podLabels[key]; ok && podLabels[key] == value { continue } else { judge = false break } } } if judge { // Assume one application only have one Application CR cr = &appCR crIsFound = true break } } ```

Leave a reaction on this issue to contribute to the project by classifying this instance as a Bug :-1:, Mitigated :+1:, or Desirable Behavior :rocket: See the descriptions of the classifications here for more information.

commit ID: 393107fedb10fee7d4501d639c4fa408eae0fd11