mdempsky
commented
3 years ago return statement after the go statement, so the loop never continues to another iteration, and so mh never gets reassigned.
Open githubvet opened 3 years ago
mdempsky
commented
3 years ago return statement after the go statement, so the loop never continues to another iteration, and so mh never gets reassigned.
Found a possible issue in mit-dci/lit at qln/multihop.go
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
Click here to see the code in its original context.
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go for _, mh := range nd.InProgMultihop { hash := fastsha256.Sum256(mh.PreImage[:]) if !bytes.Equal(mh.PreImage[:], nullBytes[:]) && bytes.Equal(msg.HHash[:], hash[:]) && mh.Path[len(mh.Path)-1].CoinType == incomingHop.CoinType { // We already know this. If we have a Preimage, then we're the receiving // end and we should send a settlement message to the // predecessor go func() { _, err := nd.ClaimHTLC(mh.PreImage) if err != nil { logging.Errorf("error claiming HTLC: %s", err.Error()) } }() return nil } } ```Leave a reaction on this issue to contribute to the project by classifying this instance as a Bug :-1:, Mitigated :+1:, or Desirable Behavior :rocket: See the descriptions of the classifications here for more information.
commit ID: 511d703a128dca889b36170d1a1d99af9a02e959