search

github / GitPad

Notepad.exe as Git commit editor
MIT License
187 stars 69 forks source link

Gracefully handle missing associations and editors #15

Closed niik closed 11 years ago

niik commented 11 years ago

See #14.

Also attaches a cleanup delegate for when people cancel out of editing through CTRL+C

anaisbetts commented 11 years ago

I hate to be a parade rainer, but the concept of this fix is broken :( Just like how Process.Start can return NULL, there may not be an EXE file associated with a file ending, yet the association might work anyways (i.e. the association might be set up via a COM object)

niik commented 11 years ago

Ah, crud. Should we perhaps try to launch, catch the missing application exception and only in that case fall back on notepad? I can get on that fix instead.

anaisbetts commented 11 years ago

Ah, crud. Should we perhaps try to launch, catch the missing application exception and only in that case fall back on notepad? I can get on that fix instead.

Yep, that sounds like a plan