github / GitPad

Notepad.exe as Git commit editor
MIT License
187 stars 69 forks source link

uninstall steps no longer correct? #25

Closed shiftkey closed 9 years ago

shiftkey commented 9 years ago

This doesn't seem right. Check the code to see if we ever look at this registry value.

How to uninstall

Remove HKEY_CURRENT_USER\Environment\EDITOR from the registry and reboot your system.

niik commented 9 years ago

We do. https://github.com/github/GitPad/blob/ac49d54ea255dd5a6c60117760c08666ec199cc2/Program.cs#L51

It's a persistent user-level environment variable picked up by git. Ideally this would be configured in .gitconfig instead (which we do in GitHub desktop) but in either case the instruction is valid.