github / GitPad

Notepad.exe as Git commit editor
MIT License
187 stars 69 forks source link

Spaces in user name crash git #33

Open mlambley opened 6 years ago

mlambley commented 6 years ago

My windows user name is "Mark Lambley". When using gitpad and doing a commit, I get an error due to the space in my name:

C:/Users/Mark Lambley/AppData/Roaming/GitPad/GitPad.exe: C:/Users/Mark: No such file or directory
error: There was a problem with the editor 'C:/Users/Mark Lambley/AppData/Roaming/GitPad/GitPad.exe'.
Please supply the message using either -m or -F option.

I have fixed this by replacing the registry entry with:

"EDITOR"="C:/Users/MARKLA~1/AppData/Roaming/GitPad/GitPad.exe"

I'm not sure whether wrapping quotes around the executable path is within the scope of this program or not, or whether or not you can store the registry path in "dir /X" format, or whether this is simply a matter of providing instructions on how to modify the registry in your readme for users who are getting this issue.