search

github / GitPad

Notepad.exe as Git commit editor
MIT License
187 stars 69 forks source link

Include Win32 error messages in exceptions #8

Closed aroben closed 12 years ago

aroben commented 12 years ago

This will help users figure out what went wrong.

haacked commented 12 years ago

How does this help? It looks like you're just adding a new Win32Exception as an inner exception without any information? Or is the empty Win32Exception itself the information we're adding? The fact that it was a Win32 exception?

haacked commented 12 years ago

Oh, and the code looks simple enough. :) :shipit:

aroben commented 12 years ago

The Win32Exception() constructor calls Marshal.GetLastWin32Error() to initialize the exception.

haacked commented 12 years ago

Ah! I did not know that. Carry on. :)