github / Rebel

Cocoa framework for improving AppKit
Other
1.13k stars 111 forks source link

RBLPopover Transient Behavior not behaving right as documented #116

Closed xiao99xiao closed 10 years ago

xiao99xiao commented 10 years ago

The comment for RBLPopoverViewControllerBehaviorTransient says:

But while the transientEventMonitor is using

[NSEvent addLocalMonitorForEventsMatchingMask:(NSLeftMouseDownMask | NSRightMouseDownMask | NSKeyUpMask) handler: ^(NSEvent *event) {...}]

Thus MouseDown outside the application will not close the popover, especially when attached to a NSStatusItem.

I suggest using addGlobalMonitorForEventsMatchingMask:handler: here instead.

xiao99xiao commented 10 years ago

I see it's already fixed long ago, ignore this please.