Closed mdiep closed 10 years ago
This makes sense to me, though I think @dannygreg should take a look.
It's no harder to subclass than the view
Not true. How do I do custom drawing? RBLPopover
isn't a view so that becomes incredibly unclear. I think the answer here is to change how we are initialising the background view. I quite like having the drawing responsibility as clear as it is now.
What kind of custom drawing do you have in mind?
What kind of custom drawing do you have in mind?
A different style of popover altogether. After all, that was the reason we created RBLPopover
in the first place.
I'd like to make popovers more customizable. Specifically, I'd like to add easy customization of the size and position of the arrow. This is difficult with the current interface for a combination of reasons:
RBLPopoverBackgroundView
. But since the actual view isn't created until you show the popover, there's not a suitable point where you can configure the view.I'd like to move the relevant properties and methods to
RBLPopover
. It's no harder to subclass than the view, and you can do almost all of the same things, but it'd also be easier to add customizable properties toRBLPopover
.This PR just changes the header at the moment because I want to get some :+1:s before I do the work.