Don't hide popover if it currently displays an alert sheet.

github / Rebel

Cocoa framework for improving AppKit

Other

1.13k stars 111 forks source link

Don't hide popover if it currently displays an alert sheet. #66

Closed falkobuttler closed 10 years ago

falkobuttler commented 11 years ago

It would lead to a crash if a delegate has been set.

jspahrsummers commented 11 years ago

Thanks for submitting this! I only have the one style nitpick above.

Assigning to @dannygreg since he's most familiar with this code.

dannygreg commented 11 years ago

Definitely a valid fix… but I would strongly recommend against displaying sheets within popovers.

Fix up that one style note that @jspahrsummers has pointed out (if you haven't already, have a peruse of our contributing guidelines and this will be good to merge, thanks for the fix! :+1: