Current PR doesn't appear on status bar when checked out from command line

[jcansdale]

Summary

A link to the active PR doesn't appear on status bar unless the user has already viewed it using the GitHub pane's PR detail view. This means that people who haven't used the extension aren't being guided towards features that would be immediately relevant.

• GitHub Extension for Visual Studio version: 2.4.3
• Visual Studio version: All

Repro

1. Clone a new repository
2. Check out PR branch from command line
3. PR doesn't appear on the status bar

Also:

UPDATE: The following is fixed in #1687

1. Clone a new repository
2. Create a PR using Create New on GitHub pane
3. PR doesn't appear on the status bar

Simple mitigation

UPDATE: The following was addressed in #1593 and #1622

At the moment the PR icon and the PR number is a single button. We only show this button when we know it's a PR branch (the branch is labeled when opened in the PR detail view). Hence, the button only appears when the has already used the GitHub pane functionality.

We could easily split the button into 2, where the PR icon opens the PR list and the PR number opens the individual PR. This would have 2 advantages.

1. It would keep the command for the PR icon consistent with the GitHub pane (opens the PR list)

2. It would guide the user towards the PR list when they're using a Git repo (when they can open or create a PR)

Proper fix

1. Label the current PR when the PR list is loaded (not when the PR is specifically opened). This would help guide the user towards the current PR after they open the PR list.
2. Label the PR when created using Create New on GitHub pane Fixed in #1687

[grokys]

Yes, this is a known issue. I'm hoping that we can solve this as we move to GraphQL.

[jcansdale]

@grokys what about when creating PRs with the extension? Should they be showing up?

[grokys]

Yes, actually we can fix that part already.