github / VisualStudio

GitHub Extension for Visual Studio
https://visualstudio.github.com
MIT License
2.36k stars 1.2k forks source link

Extension doesn't recognize my project as existing on GitHub #1709

Open jaredpar opened 6 years ago

jaredpar commented 6 years ago

When I open VsVim in Visual Studio the GitHub extension window puts up the message:

This repository is not on GitHub

This is certainly not true :smile:

As an experiment I hit the "Get Started" button and attempted to publish it hoping it would get the extension to reset a bit and find the extension. The publish failed with "there is already a repository with this name" yet it still won't connect it in Visual Studio.

I looked through the extension.log file a bit and there are too many errors for me to track down this particular problem. Or give me a hint as to what is going on.

Extension log file: https://gist.github.com/jaredpar/ee2c7110c5529e9cde6e67b048d5e925

jaredpar commented 6 years ago

Actually this error does look a bit interesting:

Error logging into '"https://github.com/"' as 'jaredpa' Octokit.RateLimitExceededException: API rate limit exceeded for user ID 146967.

My username is jaredpar, not jaredpa. Not sure if that's just a log trimming issue though.

grokys commented 6 years ago

Hi @jaredpar!

Thanks for getting in touch. This is something that happens occasionally, and we've not got to the bottom of it, so I'm going to do a dump here of all the relevant information for future reference.

SQLite is failing to load the native dll, sqlite3.dll but failing. It should be looking in C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\GitHub\GitHub\x86 but the x86 part of the path is missing from looking in your logs.

This problem has ben reported before in:

https://github.com/github/VisualStudio/issues/958 https://github.com/github/VisualStudio/issues/920

And with another extension:

https://github.com/ericsink/SQLitePCL.raw/issues/54

shana commented 6 years ago

The error message as it stands today doesn't include the fully probed path, so not having x86 in the log is expected.

@jaredpar We haven't been able to reproduce this problem, so hopefully you can help us finally track it down for good. I'm putting together a build with better error messages and a bit more robustness in loading sqlite, if you'd be willing to give it a try?

jaredpar commented 6 years ago

Happy to help. Just let me know when the build is available and what other info you need. On Wed, May 30, 2018 at 3:55 AM Andreia Gaita notifications@github.com wrote:

The error message as it stands today doesn't include the fully probed path, so not having x86 in the log is expected.

@jaredpar https://github.com/jaredpar We haven't been able to reproduce this problem, so hopefully you can help us finally track it down for good. I'm putting together a build with better error messages and a bit more robustness in loading sqlite, if you'd be willing to give it a try?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/github/VisualStudio/issues/1709#issuecomment-393118573, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI-FxhmbmJETX5rJS8jzl_ddz7W6e3Wks5t3nqZgaJpZM4USPWG .

jaredpar commented 6 years ago

Any updates here? The extension is essentially unusable in it's current state.

jcansdale commented 6 years ago

@jaredpar 👋,

I was wondering you could use procmon with filters for sqlite3.dll and devenv.exe? Hopefully that would show us where it's probing for and failing to find sqlite3.dll.

shana commented 6 years ago

I'm so sorry, it's been a rather crazy week around here and I dropped the ball on this 😢 I'll get you a build in a couple of hours!

shana commented 6 years ago

@jaredpar Try the v2.5.2.2803 vsix build at https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.2.2803/artifacts. It should either work or at least provide better error results.

jaredpar commented 6 years ago

@shana no problem on the delay. I tried that build out and it didn't address my problem.

But I did end up finding a way to solve it. The key was adding a remote named "origin". Previously I had two remotes that looked like this:

C:\Users\jaredpar\code\VsVim> git remote -v
jaredpar        https://github.com/jaredpar/VsVim.git (fetch)
jaredpar        https://github.com/jaredpar/VsVim.git (push)
rick    https://github.com/ricksladkey/VsVim.git (fetch)
rick    https://github.com/ricksladkey/VsVim.git (push)

Once I added "origin" that just pointed to the same place as "jaredpar" then the extension started working immediately.

jcansdale commented 6 years ago

@jaredpar,

Coincidentally I'm currently working on this part of the code-base. We assume that the GitHub repository associated with the local repository is pointed to by a remote called origin. We don't necessarily want to use the remote from the tracking branch because the user might be collaborating on a pull request originating from another user's repository.

Showing a link to and PRs from ricksladkeys repository probably wouldn't be very useful. Having said that, if there is no origin, it would probably make sense to fall back to using the remote from the tracking branch.

What do you think?

jaredpar commented 6 years ago

@jcansdale

That makes sense to me.

shana commented 6 years ago

@jaredpar Could you upload your log with this new build? I'm still curious to see if the sqlite exceptions have stopped

jaredpar commented 6 years ago

@shana

Could you upload your log with this new build? I'm still curious to see if the sqlite exceptions have stopped

Sure thing. Will try and get that to you tonight. Sorry for the delay. Been out of town for a week with limited email.

timdhoffmann commented 5 years ago

@jcansdale I experienced this issue as well and spent quite some time trying to figure out what's going on (had a simple typo in my remote's name). I think it would be nice to have

jcansdale commented 5 years ago

@timdhoffmann 👋

I experienced this issue as well and spent quite some time trying to figure out what's going on (had a simple typo in my remote's name).

Sorry about that! I agree the current situation isn't great.

I'm thinking maybe something along the lines of this: image

I'm terrible at wording this kind of thing, so let me know if you think of anything that would be make it clearer! Clicking the title would navigate the user to an issue with more details about this.

jaredpar commented 5 years ago

I think that experience would be perfect. The inability to specify the remote to use is a tad bit annoying. But I also realize not having origin defined is probably the 1% case. As long as there is something telling me that's the problem I can move forward.

timdhoffmann commented 5 years ago

Agree, that would be helpful.

Xottab-DUTY commented 1 year ago

Bump. My repository suddenly stopped being detected as existing on GitHub.