github / VisualStudio

GitHub Extension for Visual Studio
https://visualstudio.github.com
MIT License
2.37k stars 1.21k forks source link

Installer hangs after download of GHfVS is complete #1865

Open meaghanlewis opened 6 years ago

meaghanlewis commented 6 years ago

Version

What happened

@shana reported that on a fresh install of GHfVS the redist installer hangs after the extension is done installing.

ghfvs-first-install

"C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\vsixinstaller.exe" /appidinstallpath:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\devenv.exe" /skuName:Enterprise /skuVersion:15.0.27703.2042 /appidname:"Microsoft Visual Studio Enterprise 2017" /culture:"en-US" "C:\Users\shana\AppData\Local\Temp\VSIXrnntq5jw.vsix" (the command line it's executing, for reference)

meaghanlewis commented 6 years ago

related issue where someone installing GHfVS also has Android NDK installing: dfb7b8fvmaelfuj

grokys commented 6 years ago

cc: @AArnott @madskristensen @tinaschrepfer

AArnott commented 6 years ago

I've sent a link for this issue to the VSIX installer folks. Hopefully we'll get some traction on it.

heaths commented 6 years ago

Please run https://aka.ms/vscollect and attach %TEMP%\vslogs.zip to a new issue you can create from the Feedback button in either the Visual Studio Installer or Visual Studio itself (both in the upper-right corner).

grokys commented 6 years ago

This just happened to me. Issue opened at https://developercommunity.visualstudio.com/content/problem/321827/installer-hangs-installing-github-for-visual-studi.html with logs.

For me it failed installing sqlsysclrtypes:

image

heaths commented 6 years ago

Thanks for reporting your issue, but that is using the full installer, and it's not hanging on sqlsysclrtypes because it says "Retrying 4/10" (something - probably another Windows Installer-based install, for which only one on a machine can install at a time). We need logs for the issue when this occurs with VSIXInstaller.exe.

Let's continue this discussion on the Feedback ticket itself.

grokys commented 6 years ago

Hi @heaths - to be clear the original error was in VSIXInstaller.exe, but I forgot to screenshot it there, so I screenshotted it when i started up the main installer. The log I sent however was taken just after VSIXInstaller failed.

Will continue the discussion on the feedback ticket!