Pull Requests

[shana]

Imported from https://github.com/github/VisualStudioInternal/issues/428

So this is the broad list of things that go into PRs. I've set checkmarks on the bare minimum PR support without which there's probably no point in shipping. Any things that we wouldn't support initially would instead jump to the website to show the information, if possible.

PR Feature - Level 1

• [x] List Pull Requests
  • [x] Filtering
• [ ] Create Pull Request
  • [x] Entry form for title, description and create button
  • [ ] Assigment
  • [ ] Commit list

    PR Feature - Level 2

• [x] Create Pull Request
  • [x] Commit detail (file changes list per commit)
  • [x] File changes list (of the PR)
  • [x] Diff of file change selected (from commit detail or PR changes detail), no special adornments

    PR Feature - Level 3

• [ ] Pull Request detail
  • [ ] Commit list
  • [ ] Commit detail (file changes list )
  • [x] File changes list (of the PR)
  • [ ] Conversation list
  • [x] Diff of file change (from commit detail or PR changes list)
  • [ ] Add comment on diff view line
  • [ ] See comments on diff view line
  • [ ] Merge PR
  • [ ] Close PR

    Things to figure out

• [ ] Need a way of assigning someone to a PR
• [ ] Need a merge button somewhere
• [ ] Sorting

  Mockups

  Pull Request List

Pull Request Creation / Detail

The pull request creation wouldn't have a Conversation tab because, well, it's a new PR, but viewing an existing PR would have it. Still debating whether to use tabs or dropdowns (for space conservation), but tabs do provide useful information.

Not seen in the mockups is the ability to see individual changes list per-commit, which is a very useful feature. Considering having the commit entry as a collapsible pane that shows a list of changed files in the same way as the PR file change list.

Pull Request Detail, alternate form with pull downs

[stevekennaird]

@shana just out of interest, do you think some form of 'PR Feature - Level 2' or 'PR Feature - Level 3' will be coming any time soon? Or is it an unknown at the moment?

[shana]

@stevekennaird Yup, we're working on it, just taking a more holistic, workflow approach to it. See #491 for some of that!