search

github / VisualStudio

GitHub Extension for Visual Studio
https://visualstudio.github.com
MIT License
2.38k stars 1.2k forks source link

"Open from GitHub" experience is misleading for Enterprises on GitHub.com #2459

Open alwell-kevin opened 4 years ago

alwell-kevin commented 4 years ago

Versions

What happened

After SSO into my GitHub Organization (on GitHub.com) I attempt to clone a repository. During that clone, the "Open from GitHub" dialog prompt appears (illustrated in the image below). The text "Resource protected by organization SAML enforcement. You must grant your personal token access to this organization" is misleading developers into thinking they need to re-authenticate in some way while they actually have a valid session and can successfully access Org resources.

Screen Shot 2020-02-07 at 4 05 23 PM

Steps to Reproduce

Steps to reproduce the behavior:

  1. Login with Browser to SSO enable extension
  2. Dialog prompt appears, observe misleading text.

Expected behavior

  1. Login with Browser to SSO enable extension
  2. Some indication that I have a valid session and can access SAML protected resources.

Screenshots

Screen Shot 2020-02-07 at 4 05 23 PM

Additional context

cc: @johnjay0, @rchillara07, @mienabeard

mkarliner commented 4 years ago

Also, this file VisualStudio/docs/getting-started/authenticating-to-github.md

does not mention installing the extension, and nowhere does it say I have to close VS first.

jcansdale commented 4 years ago

Hi folks 👋

From the clone dialog, could you click on Add/Change Accounts. Then select the GitHub tab and Sign in with your browser. You should then have to option to authenticate for your SAML SSO protected organization!

image

Singing in using a username/password is being deprecated in favor of the web-flow. I'm hoping to remove the username/password option entirely to avoid this potential confusion.