github / VisualStudio

GitHub Extension for Visual Studio
https://visualstudio.github.com
MIT License
2.38k stars 1.2k forks source link

Serilog.dll can conflict with other plugins using Serilog in Visual Studio #2535

Open IvoMiller opened 4 years ago

IvoMiller commented 4 years ago

If multiple Visual Studio plugins use serilog for logging, this can cause conflicts. For example this happens when Red Gate plugins such as SQL Change Automation are installed alongside GitHub Extension for Visual Studio. This probably isn't something that can be solved in this plugin, but it would be less of an issue if this plugin were using the latest version of Serilog (it currently uses 2.5.0 and the latest is 2.7.1) and could keep it regularly updated

Versions

What happened

Errors when opening a SQL Change Automation project (note that this problem is almost certainly not limited to this plugin alone).

Steps to Reproduce

This can be reproduced by installing Red Gate SQL Change Automation alongside GitHub Extension for Visual Studio, and opening/creating a SQL Change Automation project. A reproduction shouldn't really be necessary here though.

Expected behavior

These plugins ideally shouldn't collide in any way

Screenshots

Not immediately available. Can be supplied if necessary.

Logs

Not immediately available. Can be supplied if necessary.

Additional context

-

yuakihiro commented 4 years ago

Serilog.Sinks.File is conflicting with BuildVision or other Extension serilog/serilog-sinks-file#159 StefanKert/BuildVision#97