search

github / accessibility-alt-text-bot

An action to remind users to add alt text on Issues, Pull Requests, and Discussions
MIT License
74 stars 13 forks source link

Update existing comment #31

Open mprins opened 1 year ago

mprins commented 1 year ago

When alt-text is added (and the flagged problem is resolved) the comment placed by the workflow should be removed or hidden (and marked as resolved)

kendallgassner commented 1 year ago

I am not how easy it would be to track which image the bot comment was referring to 🤔.

We might be able to add a data-attribute inside our comment: <span data-image-name={NAME_OF_IMAGE}></span>. Adding the attribute would allow us to know which comment to remove when the alt text issue is resolved...

Searching through each comment might be costly though.

cc. @khiga8

khiga8 commented 1 year ago

I love this idea!

Each comment should have a unique ID associated with it so we could try including that as a data attribute in the posted comment like @kendallgassner suggests. For example, @kendallgassner comment URL is https://github.com/github/accessibility-alt-text-bot/issues/31#issuecomment-1686597422. I believe 1686597422 is the unique issue comment ID.

Searching through each comment might be costly though.

Could we filter by bot author and comment body content?

kendallgassner commented 1 year ago

Could we filter by bot author and comment body content?

O! genius 🧠!!