search

github / accessibility-alt-text-bot

An action to remind users to add alt text on Issues, Pull Requests, and Discussions
MIT License
74 stars 13 forks source link

Simplify alt-text-bot Workflow #38

Closed kendallgassner closed 10 months ago

kendallgassner commented 10 months ago

What

As pointed out in https://github.com/JoshuaKGoldberg/create-typescript-app/issues/997 the if statement in our alt-text-bot workflow is likely unnecessary.

https://github.com/github/accessibility-alt-text-bot/blob/7932b9072f96703809a75c48c771abf33c3fb39b/.github/workflows/test-accessibility-alt-text-bot.yml#L18

Acceptance Criteria

DerTimonius commented 10 months ago

I created a small repo with the if statement removed and created an issue where I added an image without an alt text. There was no comment made by the bot, so I guess the if is necessary?

kendallgassner commented 10 months ago

@DerTimonius I tested this on my end, and it actually just looks like it was due to a version issue in the README. If you bump to 1.4.0 you do not need the if.

DerTimonius commented 10 months ago

Ah, I see. Thanks for the clarification 🙂

kendallgassner commented 10 months ago

Thanks for testing!